[
https://issues.apache.org/jira/browse/HADOOP-15327?focusedWorklogId=635085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635085
]
ASF GitHub Bot logged work on HADOOP-15327:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 11:44
Start Date: 06/Aug/21 11:44
Worklog Time Spent: 10m
Work Description: szilard-nemeth commented on a change in pull request
#3259:
URL: https://github.com/apache/hadoop/pull/3259#discussion_r684170128
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
##########
@@ -290,6 +302,36 @@ public void operationComplete(ChannelFuture future) throws
Exception {
shuffleConnections.decr();
}
}
+
+ static class NettyChannelHelper {
+ static ChannelFuture writeToChannel(Channel ch, Object obj) {
+ LOG.debug("Writing {} to channel: {}", obj.getClass().getSimpleName(),
ch.id());
+ return ch.writeAndFlush(obj);
+ }
+
+ static void writeToChannelAndClose(Channel ch, Object obj) {
Review comment:
Makes sense, also added to writeToChannelAndClose so all of the method
return types are uniform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 635085)
Time Spent: 1h 20m (was: 1h 10m)
> Upgrade MR ShuffleHandler to use Netty4
> ---------------------------------------
>
> Key: HADOOP-15327
> URL: https://issues.apache.org/jira/browse/HADOOP-15327
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Szilard Nemeth
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-15327.001.patch, HADOOP-15327.002.patch,
> HADOOP-15327.003.patch, HADOOP-15327.004.patch, HADOOP-15327.005.patch,
> HADOOP-15327.005.patch,
> getMapOutputInfo_BlockingOperationException_awaitUninterruptibly.log,
> testfailure-testMapFileAccess-emptyresponse.zip,
> testfailure-testReduceFromPartialMem.zip
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This way, we can remove the dependencies on the netty3 (jboss.netty)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
