[
https://issues.apache.org/jira/browse/HADOOP-17198?focusedWorklogId=635070&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635070
]
ASF GitHub Bot logged work on HADOOP-17198:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 11:26
Start Date: 06/Aug/21 11:26
Worklog Time Spent: 10m
Work Description: bogthe commented on a change in pull request #3260:
URL: https://github.com/apache/hadoop/pull/3260#discussion_r684160558
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -822,10 +854,21 @@ private void bindAWSClient(URI name, boolean dtEnabled)
throws IOException {
S3_CLIENT_FACTORY_IMPL, DEFAULT_S3_CLIENT_FACTORY_IMPL,
S3ClientFactory.class);
+ // If there's no endpoint set, then use the default for bucket or
AccessPoint. Overriding is
+ // useful when using FIPS or DualStack S3 endpoints.
+ String endpoint = conf.getTrimmed(ENDPOINT, "");
+ if (endpoint.isEmpty()) {
Review comment:
No, what I initially intended is to say "if you're not setting the
endpoint then I'll provide a default Access Point endpoint". This is because I
don't know what endpoint the user wants to point it to.
This is also why your tests are failing when you set the endpoint to
`ap-south-1`. I'm open to adding another `fs.s3a.accesspoint-endpoint`
configuration if it's better to provide an option to override only the access
point endpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 635070)
Time Spent: 3.5h (was: 3h 20m)
> Support S3 Access Points
> ------------------------
>
> Key: HADOOP-17198
> URL: https://issues.apache.org/jira/browse/HADOOP-17198
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Bogdan Stolojan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Improve VPC integration by supporting access points for buckets
> https://docs.aws.amazon.com/AmazonS3/latest/dev/access-points.html
> Not sure how to do this *at all*;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
