zhihaixu2012 commented on a change in pull request #3175:
URL: https://github.com/apache/hadoop/pull/3175#discussion_r670804904
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
##########
@@ -2657,6 +2657,17 @@
</description>
</property>
+<property>
+
<name>dfs.datanode.round-robin-volume-choosing-policy.additional-available-space</name>
+ <value>0</value>
Review comment:
Yes, Good suggestion. I think the reasonably default number can be 10 GB
, which is the same as the default value of
dfs.datanode.available-space-volume-choosing-policy.balanced-space-threshold.
since AvailableSpaceVolumeChoosingPolicy uses this default value as balanced
disk maximum difference. But on the other hand for better backward
compatibility, I think the default value need be more conservative. The default
maximum number of DataXceiver threads is 4096 and the average file size for a
metadata file should be less than 1K bytes. 4096 multiplied by 1k is 4 MB. I
think the better default number may be 4 MB for backward compatibility. What is
your suggestion? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
