smengcl commented on a change in pull request #2927:
URL: https://github.com/apache/hadoop/pull/2927#discussion_r623028802
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java
##########
@@ -756,6 +760,10 @@ public JSONObject execute(FileSystem fs) throws
IOException {
return toJSON(
StringUtils.toLowerCase(HttpFSFileSystem.DELETE_JSON), true);
}
+ // Same is the behavior with Delete shell command.
+ // If moveToAppropriateTrash() returns false, file deletion
+ // is attempted rather than throwing Error.
+ LOG.error("Could not move {} to Trash, attempting removal", path);
Review comment:
Let's lower this log level to `debug` instead **if we decide to make
skiptrash default to false**. `error` could generate a lot of noise if trash is
not enabled here.
When skiptrash defaults to true then I'm fine with `error`. But `warn` might
still be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
