[GitHub] [hadoop] tomscut commented on pull request #2933: HDFS-15991. Add location into datanode info for NameNodeMXBean

Wed, 21 Apr 2021 06:14:19 -0700 


tomscut commented on pull request #2933:
URL: https://github.com/apache/hadoop/pull/2933#issuecomment-824051303


   > @tomscut Thanks for working on this. It makes sense to me. Some comments,
   > 
   > * Could you add unit tests? We may want to edit TestNameNodeMXBean.
   > * Router WebUI uses the location information. Could you do the same for 
NameNode WebUI?
   > 
   > Router WebUI (federationhealth.html)
   > 
![image](https://user-images.githubusercontent.com/11712443/115539064-7d5f5480-a2d7-11eb-97a0-78adb80a2158.png)
   > 
   > NameNode WebUI (dfshealth.html)
   > 
![image](https://user-images.githubusercontent.com/11712443/115539120-90722480-a2d7-11eb-8150-258d0ff5ac91.png)
   
   Thanks @tasanuma for your review and comment. I'll refine that ASAP.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to