sodonnel commented on a change in pull request #2817:
URL: https://github.com/apache/hadoop/pull/2817#discussion_r601450951
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
##########
@@ -39,13 +39,16 @@
import java.nio.channels.SocketChannel;
import java.nio.channels.UnresolvedAddressException;
import java.util.Map.Entry;
+import java.util.concurrent.TimeUnit;
import java.util.regex.Pattern;
import java.util.*;
import java.util.concurrent.ConcurrentHashMap;
import javax.net.SocketFactory;
import org.apache.hadoop.security.AccessControlException;
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
Review comment:
I don't believe checkstyle checks for it or warns about it, however it
is good practice to keep them ordered. I sorted them in Intellij and there are
quite a few out of order, so I think it may cause more problems that it fixes
if we sort them all.
However in checking with Intellij, it moved com.google.common.cache.Cache ->
org.apache.hadoop.thirdparty.com.google.common.cache.Cache. This was part of
HADOOP-17288 which is on branch-3.3.
I will push a new commit with the new thirdparty change, but I think we
should just leave the order as it is. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
