steveloughran commented on a change in pull request #2638:
URL: https://github.com/apache/hadoop/pull/2638#discussion_r590663774



##########
File path: 
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestCommonConfigurationFields.java
##########
@@ -142,6 +141,7 @@ public void initializeMemberVariables() {
     xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.webhdfs.impl");
     xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.wasb.impl");
     xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.swift.impl");
+    xmlPropsToSkipCompare.add("fs.viewfs.overload.scheme.target.gs.impl");

Review comment:
       yeah, but lets try not to make things worse. It's like how we try and 
follow ordering/layout rules on imports. Strive to to better than your 
predecessors




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to