[
https://issues.apache.org/jira/browse/HADOOP-17451?focusedWorklogId=534272&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-534272
]
ASF GitHub Bot logged work on HADOOP-17451:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/21 14:55
Start Date: 11/Jan/21 14:55
Worklog Time Spent: 10m
Work Description: mukund-thakur commented on a change in pull request
#2594:
URL: https://github.com/apache/hadoop/pull/2594#discussion_r555093592
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInstrumentation.java
##########
@@ -1470,7 +1456,7 @@ public void blockUploadFailed(
@Override
public void bytesTransferred(long byteCount) {
bytesUploaded.addAndGet(byteCount);
- incrementGauge(STREAM_WRITE_BLOCK_UPLOADS_BYTES_PENDING, -byteCount);
+ incAllGauges(STREAM_WRITE_BLOCK_UPLOADS_BYTES_PENDING, -byteCount);
Review comment:
nit: why change in name as still only one guage is being incremented in
the method underneath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 534272)
Time Spent: 2h 10m (was: 2h)
> intermittent failure of S3A tests which make assertions on
> statistics/IOStatistics
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-17451
> URL: https://issues.apache.org/jira/browse/HADOOP-17451
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Intermittent failure of ITestHuge* upload tests, when doing parallel test
> runs.
> The count of bytes uploaded through StorageStatistics isn't updated. Maybe
> the expected counter isn't updated, and somehow in a parallel run with
> recycled FS instances/set up directory structure this surfaces the way it
> doesn't in a single test run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
