[ 
https://issues.apache.org/jira/browse/HADOOP-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251806#comment-17251806
 ] 

Ayush Saxena edited comment on HADOOP-17439 at 12/18/20, 3:32 PM:
------------------------------------------------------------------

I want to do that, Not sure if the process allows that, The crazy thing is Hive 
worked for me with this patch I ran a couple of unit tests as well from hive 
which fails with NoClassDef error if you don't have this patch, With this they 
were passing. {{hive-exec}} I guess shades guava? So from that side it 
shouldn't be problem. Yahh, but if hive-classpath is blindly taking the entire 
hadoop-classpath, we should fix this at hive, The other common dependencies 
like netty and stuff can bother too, if both hadoop and hive has different 
versions?

If that is surfacing then while upgrading any downstream project, they 
can/should exclude guava from hadoop from there classpath.
This patch gives a doable way, some doable changes downstream still have to do, 
this paves out a way to do so. Makes things simple, not trivial enough that 
just change the number


was (Author: ayushtkn):
I want to do that, Not sure if the process allows that, The crazy thing is Hive 
worked for me with this patch I ran a couple of unit tests as well from hive 
which fails with NoClassDef error if you don't have this patch, With this they 
were passing. {{hive-exec}} I guess shades guava? So from that side it 
shouldn't be problem. Yahh, but if hive-classpath is blindly taking the entire 
hadoop-classpath, we should fix this at hive, The other common dependencies 
like netty and stuff can bother too, if both hadoop and hive has different 
versions?

> No shade guava in trunk
> -----------------------
>
>                 Key: HADOOP-17439
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17439
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Lisheng Sun
>            Priority: Major
>         Attachments: image-2020-12-18-22-01-45-424.png
>
>
> !image-2020-12-18-22-01-45-424.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to