[
https://issues.apache.org/jira/browse/HADOOP-17138?focusedWorklogId=522947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-522947
]
ASF GitHub Bot logged work on HADOOP-17138:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/20 00:32
Start Date: 11/Dec/20 00:32
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2538:
URL: https://github.com/apache/hadoop/pull/2538#issuecomment-742888191
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 32m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ branch-3.3 Compile Tests _ |
| +0 :ok: | mvndep | 3m 52s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 33m 47s | branch-3.3 passed |
| +1 :green_heart: | compile | 23m 9s | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 3m 38s | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 13m 59s | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 38m 36s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 6m 49s | branch-3.3 passed |
| +0 :ok: | spotbugs | 0m 54s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| -1 :x: | findbugs | 15m 5s | hadoop-yarn-project/hadoop-yarn in
branch-3.3 has 2 extant findbugs warnings. |
| -1 :x: | findbugs | 0m 43s | hadoop-cloud-storage-project/hadoop-cos
in branch-3.3 has 1 extant findbugs warnings. |
| -1 :x: | findbugs | 0m 53s |
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
in branch-3.3 has 2 extant findbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 12m 2s | the patch passed |
| +1 :green_heart: | compile | 19m 43s | the patch passed |
| +1 :green_heart: | javac | 19m 43s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 58s | the patch passed |
| +1 :green_heart: | mvnsite | 12m 35s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | shadedclient | 16m 57s | patch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 5m 37s | the patch passed |
| +1 :green_heart: | findbugs | 2m 17s | hadoop-common in the patch
passed. |
| +1 :green_heart: | findbugs | 3m 29s | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | findbugs | 13m 18s |
hadoop-yarn-project/hadoop-yarn generated 0 new + 0 unchanged - 2 fixed = 0
total (was 2) |
| +1 :green_heart: | findbugs | 0m 51s |
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) |
| +1 :green_heart: | findbugs | 4m 17s | hadoop-mapreduce-project in
the patch passed. |
| +1 :green_heart: | findbugs | 0m 54s | hadoop-sls in the patch
passed. |
| +1 :green_heart: | findbugs | 0m 42s |
hadoop-cloud-storage-project/hadoop-cos generated 0 new + 0 unchanged - 1 fixed
= 0 total (was 1) |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 58s | hadoop-common in the patch passed. |
| -1 :x: | unit | 116m 11s | hadoop-hdfs in the patch passed. |
| -1 :x: | unit | 223m 21s | hadoop-yarn in the patch passed. |
| +1 :green_heart: | unit | 15m 57s |
hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. |
| +1 :green_heart: | unit | 152m 59s | hadoop-mapreduce-project in the
patch passed. |
| -1 :x: | unit | 12m 40s | hadoop-sls in the patch passed. |
| +1 :green_heart: | unit | 0m 45s | hadoop-cos in the patch passed. |
| +1 :green_heart: | asflicense | 1m 10s | The patch does not generate
ASF License warnings. |
| | | 802m 1s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.ftp.TestFTPFileSystem |
| | hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
| | hadoop.hdfs.TestDistributedFileSystem |
| | hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport |
| | hadoop.yarn.applications.distributedshell.TestDistributedShell |
| | hadoop.yarn.client.api.impl.TestAMRMClient |
| | hadoop.yarn.server.resourcemanager.TestRMHATimelineCollectors |
| | hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
|
| |
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
| | hadoop.yarn.sls.appmaster.TestAMSimulator |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2538 |
| Optional Tests | dupname asflicense xml compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux eb91fce54196 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / e4cab4b |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~16.04-b01 |
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn-warnings.html
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/branch-findbugs-hadoop-cloud-storage-project_hadoop-cos-warnings.html
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice-hbase-tests-warnings.html
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/artifact/out/patch-unit-hadoop-tools_hadoop-sls.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/testReport/ |
| Max. process+thread count | 3243 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
hadoop-mapreduce-project hadoop-tools/hadoop-sls
hadoop-cloud-storage-project/hadoop-cos U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2538/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 522947)
Time Spent: 40m (was: 0.5h)
> Fix spotbugs warnings surfaced after upgrade to 4.0.6
> -----------------------------------------------------
>
> Key: HADOOP-17138
> URL: https://issues.apache.org/jira/browse/HADOOP-17138
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Spotbugs 4.0.6 generated additional warnings.
> {noformat}
> $ find . -name findbugsXml.xml | xargs -n 1
> /opt/spotbugs-4.0.6/bin/convertXmlToText -longBugCodes
> M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in
> org.apache.hadoop.ipc.Server$ConnectionManager.decrUserConnections(String)
> At Server.java:[line 3729]
> M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L5 in
> org.apache.hadoop.ipc.Server$ConnectionManager.incrUserConnections(String)
> At Server.java:[line 3717]
> H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method
> org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(Object)
> overrides the nullness annotation of parameter $L1 in an incompatible way
> At DatasetVolumeChecker.java:[line 322]
> H D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method
> org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker$ResultHandler.onSuccess(VolumeCheckResult)
> overrides the nullness annotation of parameter result in an incompatible way
> At DatasetVolumeChecker.java:[lines 358-376]
> M D NP_METHOD_PARAMETER_TIGHTENS_ANNOTATION NP: Method
> org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker$2.onSuccess(Object)
> overrides the nullness annotation of parameter result in an incompatible way
> At ThrottledAsyncChecker.java:[lines 170-175]
> M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L8 in
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.incrOpCount(FSEditLogOpCodes,
> EnumMap, Step, StartupProgress$Counter) At FSEditLogLoader.java:[line 1241]
> M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be
> non-null but is marked as nullable At LocatedFileStatusFetcher.java:[lines
> 380-397]
> M D NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE NP: result must be
> non-null but is marked as nullable At LocatedFileStatusFetcher.java:[lines
> 291-309]
> M D DLS_DEAD_LOCAL_STORE DLS: Dead store to $L6 in
> org.apache.hadoop.yarn.sls.SLSRunner.increaseQueueAppNum(String) At
> SLSRunner.java:[line 816]
> H C UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS UMAC: Uncallable method
> org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage$1.getInstance()
> defined in anonymous class At
> TestTimelineReaderWebServicesHBaseStorage.java:[line 87]
> M D DLS_DEAD_LOCAL_STORE DLS: Dead store to entities in
> org.apache.hadoop.yarn.server.timelineservice.storage.TestTimelineReaderHBaseDown.checkQuery(HBaseTimelineReaderImpl)
> At TestTimelineReaderHBaseDown.java:[line 190]
> M V EI_EXPOSE_REP EI:
> org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may expose
> internal representation by returning CosNInputStream$ReadBuffer.buffer At
> CosNInputStream.java:[line 87]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
