[
https://issues.apache.org/jira/browse/HADOOP-16649?focusedWorklogId=504173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504173
]
ASF GitHub Bot logged work on HADOOP-16649:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/20 14:00
Start Date: 23/Oct/20 14:00
Worklog Time Spent: 10m
Work Description: ThAccart commented on pull request #2385:
URL: https://github.com/apache/hadoop/pull/2385#issuecomment-715360780
Hi
thanks for your comment.
The new code keeps the privious pattern matching test (sorry for the
misleading title) : it will accept a new param only if it is not found using
the previous pattern testing and not found using an equality testing (to
address the hadoop-azure hadoop-azure-datalake)
I also added a specific test for the pattern matching :
@test "hadoop_add_param (HADOOP-16649 c )" {
hadoop_add_param testvar Xmx -Xmx2048
hadoop_add_param testvar Xmx -Xmx128
hadoop_add_param testvar Xms -Xms32
echo ">${testvar}<"
[ "${testvar}" = "-Xmx2048 -Xms32" ]
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504173)
Time Spent: 1.5h (was: 1h 20m)
> Defining hadoop-azure and hadoop-azure-datalake in HADOOP_OPTIONAL_TOOLS will
> ignore hadoop-azure
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-16649
> URL: https://issues.apache.org/jira/browse/HADOOP-16649
> Project: Hadoop Common
> Issue Type: Bug
> Components: bin
> Affects Versions: 3.2.1
> Environment: Shell, but it also trickles down into all code using
> `FileSystem`
> Reporter: Tom Lous
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When defining both `hadoop-azure` and `hadoop-azure-datalake` in
> HADOOP_OPTIONAL_TOOLS in `conf/hadoop-env.sh`, `hadoop-azure` will get
> ignored.
> eg setting this:
> HADOOP_OPTIONAL_TOOLS="hadoop-azure-datalake,hadoop-azure"
>
> with debug on:
>
> DEBUG: Profiles: importing
> /opt/hadoop/libexec/shellprofile.d/hadoop-azure-datalake.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure-datalake
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES
> DEBUG: HADOOP_SHELL_PROFILES declined hadoop-azure hadoop-azure
>
> whereas:
>
> HADOOP_OPTIONAL_TOOLS="hadoop-azure"
>
> with debug on:
> DEBUG: Profiles: importing /opt/hadoop/libexec/shellprofile.d/hadoop-azure.sh
> DEBUG: HADOOP_SHELL_PROFILES accepted hadoop-azure
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
