[
https://issues.apache.org/jira/browse/HADOOP-16830?focusedWorklogId=479637&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479637
]
ASF GitHub Bot logged work on HADOOP-16830:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/20 13:23
Start Date: 07/Sep/20 13:23
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #2069:
URL: https://github.com/apache/hadoop/pull/2069#issuecomment-688323653
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 3s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 2s | No case conflicting files
found. |
| +0 :ok: | markdownlint | 0m 1s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
38 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 3m 22s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 16s | trunk passed |
| +1 :green_heart: | compile | 20m 50s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 17m 32s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 3m 1s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 54s | trunk passed |
| +1 :green_heart: | shadedclient | 22m 4s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 24s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 2m 26s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 1m 9s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 41s | trunk passed |
| -0 :warning: | patch | 1m 28s | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 55s | the patch passed |
| +1 :green_heart: | compile | 20m 9s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | javac | 20m 9s |
root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 generated 2 new + 2061 unchanged -
1 fixed = 2063 total (was 2062) |
| +1 :green_heart: | compile | 17m 37s | the patch passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| -1 :x: | javac | 17m 37s |
root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 2 new + 1955 unchanged -
1 fixed = 1957 total (was 1956) |
| -0 :warning: | checkstyle | 2m 56s | root: The patch generated 16 new
+ 266 unchanged - 26 fixed = 282 total (was 292) |
| +1 :green_heart: | mvnsite | 2m 53s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 14 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | shadedclient | 15m 34s | patch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 22s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| -1 :x: | javadoc | 1m 27s |
hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 1 new
+ 1 unchanged - 0 fixed = 2 total (was 1) |
| +1 :green_heart: | javadoc | 0m 26s | hadoop-mapreduce-client-core in
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.
|
| +1 :green_heart: | javadoc | 0m 34s |
hadoop-tools_hadoop-aws-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 0 new +
0 unchanged - 4 fixed = 0 total (was 4) |
| -1 :x: | findbugs | 2m 21s | hadoop-common-project/hadoop-common
generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 58s | hadoop-common in the patch passed.
|
| +1 :green_heart: | unit | 6m 56s | hadoop-mapreduce-client-core in
the patch passed. |
| +1 :green_heart: | unit | 1m 39s | hadoop-aws in the patch passed. |
| +1 :green_heart: | asflicense | 0m 47s | The patch does not generate
ASF License warnings. |
| | | 196m 42s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.MeanStatistic.samples; locked 68% of time
Unsynchronized access at MeanStatistic.java:68% of time Unsynchronized access
at MeanStatistic.java:[line 122] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.statistics.MeanStatistic.sum; locked 69% of time
Unsynchronized access at MeanStatistic.java:69% of time Unsynchronized access
at MeanStatistic.java:[line 214] |
| | org.apache.hadoop.fs.statistics.MeanStatistic.getSamples() is
unsynchronized, org.apache.hadoop.fs.statistics.MeanStatistic.setSamples(long)
is synchronized At MeanStatistic.java:synchronized At
MeanStatistic.java:[line 122] |
| | org.apache.hadoop.fs.statistics.MeanStatistic.getSum() is
unsynchronized, org.apache.hadoop.fs.statistics.MeanStatistic.setSum(long) is
synchronized At MeanStatistic.java:synchronized At MeanStatistic.java:[line
114] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/2069 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle markdownlint xml |
| uname | Linux 4ec47d3afba3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 34fe74da0e9 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/diff-compile-javac-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javac |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/diff-compile-javac-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/diff-checkstyle-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/whitespace-eol.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/testReport/ |
| Max. process+thread count | 1344 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
hadoop-tools/hadoop-aws U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2069/17/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 479637)
Time Spent: 1h (was: 50m)
> Add public IOStatistics API; S3A to support
> -------------------------------------------
>
> Key: HADOOP-16830
> URL: https://issues.apache.org/jira/browse/HADOOP-16830
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs, fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Applications like to collect the statistics which specific operations take,
> by collecting exactly those operations done during the execution of FS API
> calls by their individual worker threads, and returning these to their job
> driver
> * S3A has a statistics API for some streams, but it's a non-standard one;
> Impala &c can't use it
> * FileSystem storage statistics are public, but as they aren't cross-thread,
> they don't aggregate properly
> Proposed
> # A new IOStatistics interface to serve up statistics
> # S3A to implement
> # other stores to follow
> # Pass-through from the usual wrapper classes (FS data input/output streams)
> It's hard to think about how best to offer an API for operation context
> stats, and how to actually implement.
> ThreadLocal isn't enough because the helper threads need to update on the
> thread local value of the instigator
> My Initial PoC doesn't address that issue, but it shows what I'm thinking of
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
