[
https://issues.apache.org/jira/browse/HADOOP-17227?focusedWorklogId=477980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477980
]
ASF GitHub Bot logged work on HADOOP-17227:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/20 17:08
Start Date: 02/Sep/20 17:08
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2254:
URL: https://github.com/apache/hadoop/pull/2254#issuecomment-685873527
aah, the builder API raises checkstyles
```
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java:762:
public static final String PURPOSE = "destroy the Metadata Store including
its": Line is longer than 80 characters (found 83). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:933:
public ScanArgsBuilder withSourceFS(final FileSystem sourceFS) {:58:
'sourceFS' hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:939:
public ScanArgsBuilder withPath(final Path path) {:48: 'path' hides a
field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:945:
public ScanArgsBuilder withDoPurge(final boolean doPurge) {:54: 'doPurge'
hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:951:
public ScanArgsBuilder withMinMarkerCount(final int minMarkerCount) {:57:
'minMarkerCount' hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:957:
public ScanArgsBuilder withMaxMarkerCount(final int maxMarkerCount) {:57:
'maxMarkerCount' hides a field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:963:
public ScanArgsBuilder withLimit(final int limit) {:48: 'limit' hides a
field. [HiddenField]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:969:
public ScanArgsBuilder withNonAuth(final boolean nonAuth) {:54: 'nonAuth'
hides a field. [HiddenField]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 477980)
Time Spent: 1h 10m (was: 1h)
> improve s3guard markers command line tool
> -----------------------------------------
>
> Key: HADOOP-17227
> URL: https://issues.apache.org/jira/browse/HADOOP-17227
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The s3guard markers audit -expected N command is meant to verify that the
> marker count is N, but
> * it isn't verified if the #of markers is 0, so you can't use it to assert
> that markers have been created
> * it doesn't work for tests where you expect a minimum number of markers.
> It's essentially setting a max #of markers
> Proposed: explicit -min, -max args to declare a specific range of values
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
