bilaharith commented on pull request #2202: URL: https://github.com/apache/hadoop/pull/2202#issuecomment-679095848
> This is a big change to the test set up. > > My ability to review this is hampered by the fact there is no explanation in the JIRA or PR as to what it is directly trying to do. > > Proposed > > * a paragraph in both outlining what your goal is > * details in testing_azure.md, including detailed instructions for people writing new test as to what they are expected to do. > > Now is it is now a requirement that people running tests have multiple authentication mechanisms? Because we been having problems recently with test to have different expectations from some of us testers. Will this help there or would it make things worse? > > Various tests are fiddling with test timeouts. Either things have got very slow are you been changing them so you can debug stuff. If you do have to multiply what there is, why not make this a single constant? > > finally, my comments on imports are predictable. Save time by guessing what I will say. Thanks @steveloughran for the comments. I have still kept this PR as draft(work in progress). The comments will be addressed once the same is ready to review. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
