steveloughran commented on a change in pull request #2149:
URL: https://github.com/apache/hadoop/pull/2149#discussion_r467966105
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/InconsistentAmazonS3Client.java
##########
@@ -330,7 +330,9 @@ private boolean isDescendant(String parent, String child,
boolean recursive) {
} else {
Path actualParentPath = new Path(child).getParent();
Path expectedParentPath = new Path(parent);
- return actualParentPath.equals(expectedParentPath);
+ // children which are directory markers are excluded here
+ return actualParentPath.equals(expectedParentPath)
Review comment:
well, the code already did that direct return
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
