steveloughran commented on pull request #2159: URL: https://github.com/apache/hadoop/pull/2159#issuecomment-671372302
I I can see why adding this to hadoop-common appeals in terms of ease of redistribution, but I want it in its own package, such as hadoop-tools/hadoop-compression * hadoop-common gets everywhere -so will a new JAR, potentially causing issues downstream. * if it is in its own module, we can be on 100% sure that changes in that module Will not have any side-effects in any bit of the deep which does not import it. * If you followed up this patch with some backports of the module to 3.1.x and 3.2.x, then again it would be nicely isolated. There is a cost to this: you don't get it without changing your pom/sbt/gradle dependencies. We could think about including a stub hadoop-compression module even in those releases which don't get a backport. There is a variant option: add it to hadoop-extras, which has been around for a long time and currently it doesn't do much. Add it there and while downstream apps have to extend their pom, everything will build against older versions if they do that? The more I think about that the more I like it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
