umamaheswararao commented on a change in pull request #2100:
URL: https://github.com/apache/hadoop/pull/2100#discussion_r445927183
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/ViewFsOverloadScheme.md
##########
@@ -150,6 +150,39 @@ DFSAdmin commands with View File System Overload Scheme
Please refer to the [HDFSCommands
Guide](./HDFSCommands.html#dfsadmin_with_ViewFsOverloadScheme)
+Accessing paths without authority
+-------------------------------------------------------
Review comment:
Probably you can removed additional '_' chars after heading above.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFileSystemOverloadSchemeWithHdfsScheme.java
##########
@@ -236,6 +238,61 @@ public void testListStatusOnNonMountedPath() throws
Exception {
}
}
+ /**
+ * Create mount links as follows
+ * hdfs://localhost:xxx/HDFSUser --> hdfs://localhost:xxx/HDFSUser/
+ * hdfs://localhost:xxx/local --> file://TEST_ROOT_DIR/root/
+ * Check that "viewfs:/" paths without authority can work when the
+ * default mount table name is set correctly.
+ */
+ @Test
+ public void testAccessViewFsPathWithoutAuthority() throws Exception {
+ final Path hdfsTargetPath = new Path(defaultFSURI + HDFS_USER_FOLDER);
+ addMountLinks(defaultFSURI.getAuthority(),
+ new String[] {HDFS_USER_FOLDER, LOCAL_FOLDER },
+ new String[] {hdfsTargetPath.toUri().toString(),
+ localTargetDir.toURI().toString() },
+ conf);
+
+ // /HDFSUser/test
+ Path hdfsDir = new Path(HDFS_USER_FOLDER, "test");
+ // /local/test
+ Path localDir = new Path(LOCAL_FOLDER, "test");
+ FileStatus[] expectedStatus;
+
+ try (FileSystem fs = FileSystem.get(conf)) {
+ fs.mkdirs(hdfsDir); // /HDFSUser/testfile
Review comment:
Tiny nit: in the comment: // /HDFSUser/testfile --> // /HDFSUser/test ?
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/Constants.java
##########
@@ -41,12 +41,17 @@
* then the hadoop default value (/user) is used.
*/
public static final String CONFIG_VIEWFS_HOMEDIR = "homedir";
-
+
+ /**
+ * Config key to specify the name of the default mount table.
+ */
+ public static final String CONFIG_VIEWFS_DEFAULT_MOUNT_TABLE_NAME_KEY =
"fs.viewfs.mounttable.default.name.key";
Review comment:
Thank you for adding doc. It looks good to me.
You may want to remove "public static final" in above constant as they are
implicitly same in interface. checkstyle would be happy with that. :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
