esahekmat commented on a change in pull request #1904:
URL: https://github.com/apache/hadoop/pull/1904#discussion_r443357916
##########
File path:
hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestRolloverSignerSecretProvider.java
##########
@@ -36,23 +36,26 @@ public void testGetAndRollSecrets() throws Exception {
Assert.assertEquals(2, allSecrets.length);
Assert.assertArrayEquals(secret1, allSecrets[0]);
Assert.assertNull(allSecrets[1]);
- Thread.sleep(rolloverFrequency + 2000);
+ synchronized (secretProvider.monitor){
Review comment:
I did it but is it correct to have a VisibleForTesting method in
TRolloverSignerSecretProvider? consider that this class is an inner class of
the test class itself
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
