bilaharith commented on a change in pull request #2021:
URL: https://github.com/apache/hadoop/pull/2021#discussion_r425324373
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -131,7 +135,7 @@ public String getFileSystem() {
return filesystem;
}
- protected AbfsPerfTracker getAbfsPerfTracker() {
+ public AbfsPerfTracker getAbfsPerfTracker() {
Review comment:
Widening the method accessibility by making it public solely for testing
is not a good practice. See if at least the acces can be restricted to package
level and use @VisibleForTesting annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
