liuml07 commented on issue #1964: URL: https://github.com/apache/hadoop/pull/1964#issuecomment-617985449
Looks good to me overall. May need a clean QA run before committing. Test failure seem unrelated, but worth another look. And we can search recent builds to see if they are also happening without this patch. The `compile` issue is unrelated, reported by https://issues.apache.org/jira/browse/HADOOP-17007 `findbugs` warnings are unrelated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
