steveloughran commented on a change in pull request #1899: HADOOP-16914 Adding
Output Stream Counters in ABFS
URL: https://github.com/apache/hadoop/pull/1899#discussion_r408177932
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java
##########
@@ -383,4 +391,34 @@ protected AbfsDelegationTokenManager
getDelegationTokenManager()
throws IOException {
return getFileSystem().getDelegationTokenManager();
}
+
+ /**
+ * Generic assert method.
+ *
+ * @param operation operation being asserted.
+ * @param expectedValue value that is expected.
+ * @param actualValue value that is actual.
+ */
+ protected void assertValues(String operation, long expectedValue,
Review comment:
too vague a name and no obvious difference with assertEquals.
Propose:
* leave existing test alone,
and then one of
* use Junit assertEquals()
* or Assertions.assertThat(object).describedAs().equals().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
