[
https://issues.apache.org/jira/browse/HADOOP-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080844#comment-17080844
]
Hadoop QA commented on HADOOP-5943:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 8s{color}
| {color:red} HADOOP-5943 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-5943 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12892089/HADOOP-5943.03.patch |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/16868/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> IOUtils#copyBytes methods should not close streams that are passed in as
> parameters
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-5943
> URL: https://issues.apache.org/jira/browse/HADOOP-5943
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Reporter: Hairong Kuang
> Assignee: Andras Bokor
> Priority: Major
> Attachments: HADOOP-5943.01.patch, HADOOP-5943.02.patch,
> HADOOP-5943.03.patch
>
>
> The following methods in IOUtils close the streams that are passed in as
> parameters. Calling these methods can easily trigger findbug OBL: Method may
> fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION). A good
> practice should be to close a stream in the same method where the stream is
> opened.
> public static void copyBytes(InputStream in, OutputStream out, int buffSize,
> boolean close)
> public static void copyBytes(InputStream in, OutputStream out, Configuration
> conf, boolean close)
> These methods should be deprecated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
