steveloughran commented on a change in pull request #1899: HADOOP-16914 Adding
Output Stream Counters in ABFS
URL: https://github.com/apache/hadoop/pull/1899#discussion_r405022610
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -279,6 +283,7 @@ public synchronized void close() throws IOException {
threadExecutor.shutdownNow();
}
}
+ LOG.debug("Closing AbfsOutputStream ", toString());
Review comment:
let's guard this with a LOG.isDebugEnabled(), because that toString()
operation is doing enough work. Or, use `this` as the argument and have SLF4J
Call this.toString() only if it is printing the log entry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
