mukund-thakur commented on a change in pull request #1899: HADOOP-16914 Adding
Output Stream Counters in ABFS
URL: https://github.com/apache/hadoop/pull/1899#discussion_r402070920
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsOutputStream.java
##########
@@ -80,6 +82,7 @@
= new ElasticByteBufferPool();
private final Statistics statistics;
+ private final AbfsOutputStreamStatisticsImpl outputStreamStatistics;
Review comment:
We should be defining here using the interface not concrete class and
initialising it in constructor with concrete class implementation. That whole
point of using interface is we can change add the new implementation in future
and change the the implementation to be used in constructor using some
configuration. Right @steveloughran?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
