steveloughran commented on a change in pull request #1872: Hadoop 16890: Change
in expiry calculation for MSI token provider
URL: https://github.com/apache/hadoop/pull/1872#discussion_r389573794
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/AzureADAuthenticator.java
##########
@@ -408,17 +409,30 @@ private static AzureADToken
parseTokenFromStream(InputStream httpResponseStream)
if (fieldName.equals("access_token")) {
token.setAccessToken(fieldValue);
}
+
if (fieldName.equals("expires_in")) {
Review comment:
I'd like some reporting of parse failures here, especially which field isn't
parsing.
Also, make sure that the code is validating content type before JSON
parsing. We've done that for OAuth, needs to be done here so that a bad URL or
proxy returns HTML and everything fails for no obvious reason
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
