mukund-thakur commented on a change in pull request #1875: HADOOP-16794. S3A
reverts KMS encryption to the bucket's default KMS …
URL: https://github.com/apache/hadoop/pull/1875#discussion_r388805859
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java
##########
@@ -42,11 +46,24 @@
protected Configuration createConfiguration() {
Configuration conf = super.createConfiguration();
S3ATestUtils.disableFilesystemCaching(conf);
- conf.set(Constants.SERVER_SIDE_ENCRYPTION_ALGORITHM,
- getSSEAlgorithm().getMethod());
+ patchConfigurationEncryptionSettings(conf);
return conf;
}
+ /**
+ * This removes the encryption settings from the
Review comment:
I tried setting the bucket level conf for
fs.s3a.bucket.mthakur-data.server-side-encryption.key and some tests for eg.
ITestS3AEncryptionSSES3 started failing. I even tried adding the
removeBaseAndBucketOverrides call but it doesn't help.
I tried setting then same bucket level conf in apache/trunk as well and the
tests are succeeding there.
The reason for test failure is
`java.io.IOException: AES256 is enabled but an encryption key was set in
fs.s3a.server-side-encryption.key (key of length 76 ending with 8)
at
org.apache.hadoop.fs.s3a.S3AUtils.getEncryptionAlgorithm(S3AUtils.java:1440)
at
org.apache.hadoop.fs.s3a.S3AFileSystem.initialize(S3AFileSystem.java:316)
at
org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3298)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:476)`
removeBaseAndBucketOverrides() call essentially removes this parameter not
sure how it is getting added in FileSystem initialisation flow again. It is too
hard to compare and debug the difference between branch-3.2 and trunk as there
are many changes. Any pointers in this regards would be greatly appreciated.
Also could someone please trigger the test based on their configs and share
the results. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
