steveloughran commented on a change in pull request #1878: HADOOP-16909 Typo in
distcp counters
URL: https://github.com/apache/hadoop/pull/1878#discussion_r388462964
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/file/tfile/TestTFile.java
##########
@@ -109,15 +109,15 @@ private int readAndCheckbytes(Scanner scanner, int
start, int n)
byte[] val = readValue(scanner);
String keyStr = String.format(localFormatter, i);
String valStr = value + keyStr;
- assertTrue("btyes for keys do not match " + keyStr + " "
+ assertTrue("bytes for keys do not match " + keyStr + " "
Review comment:
pull this into a const and it could be referred everywhere.
Also, this is the time to move to assertEquals, if it does array
comparisons. If not, then never mind
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]