bgaborg commented on a change in pull request #1851: HADOOP-16858. S3Guard
fsck: Add option to remove orphaned entries
URL: https://github.com/apache/hadoop/pull/1851#discussion_r384493589
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/ITestS3GuardFsck.java
##########
@@ -599,6 +613,12 @@ private void checkForViolationInPairs(Path file,
private void checkNoViolationInPairs(Path file2,
List<S3GuardFsck.ComparePair> comparePairs,
S3GuardFsck.Violation violation) {
+
Review comment:
I don't see what you mean by that - the logging is sufficient here. Do you
mean to add javadoc to the method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
