liuml07 commented on a change in pull request #1840: HADOOP-16853.
ITestS3GuardOutOfBandOperations failing on versioned S3 buckets
URL: https://github.com/apache/hadoop/pull/1840#discussion_r378421141
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3GuardOutOfBandOperations.java
##########
@@ -969,16 +970,42 @@ private void deleteFileInListing()
deleteFile(rawFS, testFilePath);
// File status will be still readable from s3guard
- FileStatus status = guardedFs.getFileStatus(testFilePath);
+ S3AFileStatus status = (S3AFileStatus)
+ guardedFs.getFileStatus(testFilePath);
LOG.info("authoritative: {} status: {}", allowAuthoritative, status);
- expectExceptionWhenReading(testFilePath, text);
- expectExceptionWhenReadingOpenFileAPI(testFilePath, text, null);
- expectExceptionWhenReadingOpenFileAPI(testFilePath, text, status);
+ if (isVersionedChangeDetection() && status.getVersionId() != null) {
Review comment:
This is very specific to this test, which is not too long to me; and we
don't need to pass some parameters to the new helper method. I’m happy it sits
here or a new method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
