[ 
https://issues.apache.org/jira/browse/HADOOP-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096563#comment-13096563
 ] 

Bruno Mahé commented on HADOOP-7596:
------------------------------------

Anyway, this is going off-topic. I just meant to replace in your patch:
{noformat}
-  daemon --user hdfs ${HADOOP_PREFIX}/sbin/hadoop-daemon.sh --config 
"${HADOOP_CONF_DIR}" stop datanode
+  if [ -n "$HADOOP_SECURE_DN_USER" ]; then
+    daemon ${HADOOP_PREFIX}/sbin/hadoop-daemon.sh --config 
"${HADOOP_CONF_DIR}" stop datanode
+  else
+    daemon --user hdfs ${HADOOP_PREFIX}/sbin/hadoop-daemon.sh --config 
"${HADOOP_CONF_DIR}" stop datanode
+  fi
{noformat}

by something similar to what you did in the debian side. Which would look like 
something like:

{noformat}
+if [ -n "$HADOOP_SECURE_DN_USER" ]; then
+  DN_USER="root"
+else
+  DN_USER="hdfs"
+fi
{noformat}

And then later on:

{noformat}
-  daemon --user hdfs ${HADOOP_PREFIX}/sbin/hadoop-daemon.sh --config 
"${HADOOP_CONF_DIR}" stop datanode
+  daemon --user $DN_USER ${HADOOP_PREFIX}/sbin/hadoop-daemon.sh --config 
"${HADOOP_CONF_DIR}" stop datanode
{noformat}


So you end up with a similar structure as the deb side and less repetition.

> Enable jsvc to work with Hadoop RPM package
> -------------------------------------------
>
>                 Key: HADOOP-7596
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7596
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.204.0
>         Environment: Java 6, RedHat EL 5.6
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 0.20.205.0
>
>         Attachments: HADOOP-7596-2.patch, HADOOP-7596-3.patch, 
> HADOOP-7596.patch
>
>
> For secure Hadoop 0.20.2xx cluster, datanode can only run with 32 bit jvm 
> because Hadoop only packages 32 bit jsvc.  The build process should download 
> proper jsvc versions base on the build architecture.  In addition, the shell 
> script should be enhanced to locate hadoop jar files in the proper location.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to