ThomasMarquardt commented on a change in pull request #1791: HADOOP-16785: wasb
to raise IOE if write() invoked on a closed stream
URL: https://github.com/apache/hadoop/pull/1791#discussion_r363431500
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java
##########
@@ -1198,6 +1201,17 @@ public void setEncodedKey(String anEncodedKey) {
private void restoreKey() throws IOException {
store.rename(getEncodedKey(), getKey());
}
+
+ /**
+ * Check for the stream being open.
+ * @throws IOException if the stream is closed.
+ */
+ private void checkOpen() throws IOException {
Review comment:
After thinking about this, I have changed my mind and no longer think it is
necessary to check for closure inside flush, hflush, hsync, or hasCapabilities.
These are no-ops when the buffers are empty, except for hasCapabilities which
doesn't throw (so it doesn't even make sense for hasCapabilities to check).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
