[
https://issues.apache.org/jira/browse/HADOOP-16789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007848#comment-17007848
]
Chen Liang commented on HADOOP-16789:
-------------------------------------
Thanks for the catch [~Jim_Brennan]! v001 patch LGTM (good that even Jenkins
gave a green overall :) ). I've committed v001 patch to branch-2.10. Thanks for
the contribution!
> In TestZKFailoverController, restore changes from HADOOP-11149 that were
> dropped by HDFS-6440
> ---------------------------------------------------------------------------------------------
>
> Key: HADOOP-16789
> URL: https://issues.apache.org/jira/browse/HADOOP-16789
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 2.10.0
> Reporter: Jim Brennan
> Assignee: Jim Brennan
> Priority: Minor
> Attachments: HADOOP-16789-branch-2.10.001.patch
>
>
> In our automated tests, we are seeing intermittent failures in
> TestZKFailoverController. I have been unable to reproduce the failures
> locally, but in examining the code, I found a difference that may explain the
> failures.
> In trunk, HDFS-6440 ( Support more than 2 NameNodes. Contributed by Jesse
> Yates.) was checked in before HADOOP-11149. TestZKFailoverController times
> out), which changed the test added in HDFS-6440.
> In branch-2, the order was reversed, and the test that was added in HDFS-6440
> does not retain the fixes from HADOOP-11149.
> Note that there was also a change from HDFS-10985.
> (o.a.h.ha.TestZKFailoverController should not use fixed time sleep before
> assertions.) that was missed in the HDFS-6440 backport.
> My proposal is to restore the changes from HADOOP-11149. I made this change
> internally and it seems to have fixed the intermittent failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
