bharatviswa504 commented on a change in pull request #1528: HDDS-2181. Ozone
Manager should send correct ACL type in ACL requests…
URL: https://github.com/apache/hadoop/pull/1528#discussion_r333273986
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -176,12 +177,18 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
// write ACL on key. Add client id to key name if ozone native
// authorizer is configured.
Configuration config = ozoneManager.getConfiguration();
- String keyNameForAclCheck = keyName;
if (OmUtils.isNativeAuthorizerEnabled(config)) {
- keyNameForAclCheck = keyName + "/" +
allocateBlockRequest.getClientID();
+ String keyNameForAclCheck =
+ keyName + "/" + allocateBlockRequest.getClientID();
+ // During allocate block request, it is possible that key is
+ // not present in the key table and hence setting the resource type
Review comment:
Can we move this to a common method, as it is being used in KeyCommitRequest
also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
