bgaborg opened a new pull request #1576: Hadoop 16520 dynamodb ms version race refactor. URL: https://github.com/apache/hadoop/pull/1576 The following should be included: HADOOP-16349. DynamoDBMetadataStore.getVersionMarkerItem() to log at info/warn on retry. Notes: - Why there's no ITestDynamoDBMetadataStoreTableHandler if there's ITestDynamoDBMetadataStore, and why do I added the tests there? For readability and to avoid duplication. DynamoDBMetadataStoreTableHandler is just basically parts factored out from DynamoDBMetadataStore, and some helper methods. - Why there's only testTableVersioning->checkVerifyVersionMarkerCompatibility to cover the full functionality of the version marker checking and recovery with dynamo, and not 6 different methods? Creating and deleting tables takes a *lot* of time. Minutes. I use the same table during the test and add/remove the version tag and item to cover all combinations. - Why there's log on info level at DynamoDBMetadataStoreTableHandler#verifyVersionCompatibility? I think it's useful for know what's going on with the versions. It's not a lot logging at that level, but I find it useful. Things to add: - md docs about version handling - I'll add once we settled with the implementation - maybe more tests: imho the test coverage is good enough, and adding more test will take more and more testing time. But I can try to add some _non_-integration (so simple junit, surefire) tests if asked. Tested against ireland. Some tables won't be deleted for me so I get a timeout. I don't think that's related, maybe I'm just over the limit of creating and deleting tables now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
