elek commented on a change in pull request #1551: HDDS-2199 In SCMNodeManager
dnsToUuidMap cannot track multiple DNs on the same host
URL: https://github.com/apache/hadoop/pull/1551#discussion_r330473420
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
##########
@@ -398,6 +399,22 @@ public RegisteredCommand register(DatanodeDetails
datanodeDetails,
return null;
}
+ /**
+ * Add an entry to the dnsToUuidMap, which maps hostname / IP to the DNs
+ * running on that host. As each address can have many DNs running on it,
+ * this is a one to many mapping.
+ * @param dnsName String representing the hostname or IP of the node
+ * @param uuid String representing the UUID of the registered node.
+ */
+ private void addEntryTodnsToUuidMap(String dnsName, String uuid) {
Review comment:
It also can by synchronized and HashSet - > ConcurrentHashSet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
