steveloughran commented on issue #1442: HADOOP-16570. S3A committers encounter scale issues URL: https://github.com/apache/hadoop/pull/1442#issuecomment-536533462 checkstyle warnings ``` ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/files/SuccessData.java:58: * {@link org.apache.hadoop.fs.s3a.commit.CommitConstants#SUCCESS_MARKER_FILE_LIMIT}.: Line is longer than 80 characters (found 85). [LineLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:1364: "org.apache.hadoop.fs.FileSystem$Statistics$StatisticsDataReferenceCleaner");: Line is longer than 80 characters (found 85). [LineLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/StagingTestBase.java:501: public void addUploads(Map<String, String> uploads) {:48: 'uploads' hides a field. [HiddenField] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/StagingTestBase.java:605: public static AmazonS3 newMockS3Client(final ClientResults results,:3: Method length is 157 lines (max allowed is 150). [MethodLength] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/TestDirectoryCommitterScale.java:137: public void test_010_createTaskFiles() throws Exception {:15: Name 'test_010_createTaskFiles' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/TestDirectoryCommitterScale.java:208: public void test_020_loadFilesToAttempt() throws Exception {:15: Name 'test_020_loadFilesToAttempt' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/TestDirectoryCommitterScale.java:227: public void test_030_commitFiles() throws Exception {:15: Name 'test_030_commitFiles' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName] ./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/staging/TestDirectoryCommitterScale.java:257: public void test_040_abortFiles() throws Exception {:15: Name 'test_040_abortFiles' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MethodName] ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
