xiaoyuyao commented on a change in pull request #1526: HDDS-2180. Add Object ID
and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328361911
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
##########
@@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList
volumeList,
}
List<String> prevVolList = new ArrayList<>();
+ long objectID = 100;
if (volumeList != null) {
prevVolList.addAll(volumeList.getVolumeNamesList());
+ objectID = volumeList.getObjectID();
Review comment:
Here we always use the objectID of the new volumeList to replace the
existing one on line 113, is this expected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
