elek opened a new pull request #1505: HDDS-2166. Some RPC metrics are missing 
from SCM prometheus endpoint
URL: https://github.com/apache/hadoop/pull/1505
 
 
   In Hadoop metrics it's possible to register multiple metrics with the same 
name but with different tags. For example each RpcServere has an own metrics 
instance in SCM.
   
   {code}
       "name" : 
"Hadoop:service=StorageContainerManager,name=RpcActivityForPort9860",
       "name" : 
"Hadoop:service=StorageContainerManager,name=RpcActivityForPort9863",
   {code}
   
   They are converted by PrometheusSink to a prometheus metric line with proper 
name and tags. For example:
   
   {code}
   
rpc_rpc_queue_time60s_num_ops{port="9860",servername="StorageContainerLocationProtocolService",context="rpc",hostname="72736061cbc5"}
 0
   {code}
   
   The PrometheusSink uses a Map to cache all the recent values but 
unfortunately the key contains only the name (rpc_rpc_queue_time60s_num_ops in 
our example) but not the tags (port=...)
   
   For this reason if there are multiple metrics with the same name, only the 
first one will be displayed.
   
   As a result in SCM only the metrics of the first RPC server can be exported 
to the prometheus endpoint. 
   
   
   See: https://issues.apache.org/jira/browse/HDDS-2166

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to