[ 
https://issues.apache.org/jira/browse/HADOOP-7524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Todd Lipcon updated HADOOP-7524:
--------------------------------

    Attachment: rpc4.txt
                nits.txt

Hey Sanjay. Looks great. I had a few nitpicks, but rather than list them here 
and have to go back and forth I just formatted them as a diff. (nits.txt is 
just the delta, rpc4.txt is your patch with the delta applied)

+1 w/ the nits fixed.

> Change RPC to allow multiple protocols including multuple versions of the 
> same protocol
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7524
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: newPatchFindbugsWarnings.html, nits.txt, rpc2.patch, 
> rpc2_trunk.patch, rpc3.patch, rpc4.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to