bharatviswa504 commented on a change in pull request #1277: HDDS-1054. List
Multipart uploads in a bucket
URL: https://github.com/apache/hadoop/pull/1277#discussion_r320425899
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1270,6 +1271,58 @@ public void abortMultipartUpload(OmKeyArgs omKeyArgs)
throws IOException {
}
+ @Override
+ public OmMultipartUploadList listMultipartUploads(String volumeName,
+ String bucketName, String prefix) throws OMException {
+ Preconditions.checkNotNull(volumeName);
+ Preconditions.checkNotNull(bucketName);
+
+ metadataManager.getLock().acquireLock(BUCKET_LOCK, volumeName, bucketName);
+ try {
+
+ List<String> multipartUploadKeys =
+ metadataManager
+ .getMultipartUploadKeys(volumeName, bucketName, prefix);
+
+ List<OmMultipartUpload> collect = multipartUploadKeys.stream()
+ .map(OmMultipartUpload::from)
+ .map(upload -> {
+ String dbKey = metadataManager
+ .getOzoneKey(upload.getVolumeName(),
+ upload.getBucketName(),
+ upload.getKeyName());
+ try {
+ Table<String, OmKeyInfo> openKeyTable =
+ metadataManager.getOpenKeyTable();
+
+ OmKeyInfo omKeyInfo =
+ openKeyTable.get(upload.getDbKey());
+ upload.setCreationTime(
+ Instant.ofEpochMilli(omKeyInfo.getCreationTime()));
+ } catch (IOException e) {
+ LOG.warn(
+ "Open key entry for multipart upload record can be read {}",
+ dbKey);
+ }
+ return upload;
+ })
+ .collect(Collectors.toList());
+
+ OmMultipartUploadList omMultipartUploadList =
+ new OmMultipartUploadList(collect);
+
+ return omMultipartUploadList;
+
+ } catch (IOException ex) {
+ LOG.error("List Multipart Uploads Failed: volume: " + volumeName +
Review comment:
LOG.error("List Multipart Uploads Failed: volume: " + volumeName +
"bucket: " + bucketName + "prefix: " + prefix, ex);
to
LOG.error("List Multipart Uploads Failed: volume: {} bucket: {} prefix:
{}",volumeName, bucketName, prefix, ex);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
