hadoop-yetus commented on a change in pull request #1358: HDDS-2045. Partially
started compose cluster left running
URL: https://github.com/apache/hadoop/pull/1358#discussion_r318352730
##########
File path: hadoop-ozone/dist/src/main/compose/testlib.sh
##########
@@ -82,9 +82,14 @@ start_docker_env(){
local -i datanode_count=${1:-3}
docker-compose -f "$COMPOSE_FILE" down
- docker-compose -f "$COMPOSE_FILE" up -d --scale datanode="${datanode_count}"
- wait_for_datanodes "$COMPOSE_FILE" "${datanode_count}"
- sleep 10
+ docker-compose -f "$COMPOSE_FILE" up -d --scale datanode="${datanode_count}"
\
+ && wait_for_datanodes "$COMPOSE_FILE" "${datanode_count}" \
+ && sleep 10
+
+ if [[ $? -gt 0 ]]; then
Review comment:
shellcheck:9: note: Check exit code directly with e.g. 'if mycmd;', not
indirectly with $?. [SC2181]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
