ChenSammi commented on a change in pull request #1184: HDDS-1865. Use 
"ozone.network.topology.aware.read" to control both RPC client and server side 
logic
URL: https://github.com/apache/hadoop/pull/1184#discussion_r310091612
 
 

 ##########
 File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/ContainerPlacementPolicyFactory.java
 ##########
 @@ -36,7 +36,7 @@
 
   private static final Class<? extends ContainerPlacementPolicy>
       OZONE_SCM_CONTAINER_PLACEMENT_IMPL_DEFAULT =
-      SCMContainerPlacementRandom.class;
+      SCMContainerPlacementRackAware.class;
 
 Review comment:
   ContainerPlacementPolicy chosen  and topology aware read are two independent 
choice. If  SCMContainerPlacementRandom is used, we can still enable topology 
aware read as long as datanode to network location mapping is correctly built.  
   This change is committed unintentionally, I will remove it now, and enable 
the configuration after 0.4.1 is released. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to