[ 
https://issues.apache.org/jira/browse/HADOOP-16435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16892514#comment-16892514
 ] 

Zoltan Haindrich commented on HADOOP-16435:
-------------------------------------------

I don't think this is about a single session - these metrics are only used in 
the [IPC 
Server|https://github.com/apache/hadoop/blob/62deab17a33cef723d73f8d8b9e37e5bddbc1813/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java#L3075].
If you create an server and then shut it down - would you expect its metrics to 
be retained? (IMHO: if it silently retaines any information related to the 
actual instance that's a resource leak)

> RpcMetrics should not be retained forever
> -----------------------------------------
>
>                 Key: HADOOP-16435
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16435
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: rpc-server
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Critical
>         Attachments: HADOOP-16435.01.patch, classes.png, 
> defaultMetricsHoldsRpcMetrics.png, related.jxray.png, rpcm.hprof.xz
>
>
> * RpcMetrics objects are registered into 
> [defaultmetricssystem|https://github.com/apache/hadoop/blob/85d9111a88f94a5e6833cd142272be2c5823e922/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java#L101]
> * although there is a shutdown() call (which is actually invoked) it doesn't 
> unregisters itself from the 
> [metricssystem|https://github.com/apache/hadoop/blob/85d9111a88f94a5e6833cd142272be2c5823e922/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java#L185]
> * RpcDetailedMetrics has the same issue
> background
> * hiveserver2 slowly eats up memory when running simple queries in new 
> sessions (select 1)
> * every session opens a tezsession
> * tezsession has rpcmetrics
> * with a 150M heap after around 30 session the jvm gets outofmemmory



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to