steveloughran commented on issue #1134: HADOOP-16433. S3Guard: Filter expired 
entries and tombstones when lis…
URL: https://github.com/apache/hadoop/pull/1134#issuecomment-514670105
 
 
   running the tests too (non scale)
   
   One thing I want to be sure about is: does 
`DirListingMetadata.removeExpiredEntriesFromListing()` work if invoked in one 
thread while another is already doing it. I believe so, because it's using a 
ConcurrentHashMap and the javaadocs for that seem to imply it. Do you also 
believe this to be true?
   
   
   nit: now that `PathMetadata.toString()` shows the lastUpdated state, 
`DDBPathMetadata` should cut it.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to