steveloughran commented on a change in pull request #1134: HADOOP-16433.
S3Guard: Filter expired entries and tombstones when lis…
URL: https://github.com/apache/hadoop/pull/1134#discussion_r306280144
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/PathMetadata.java
##########
@@ -42,27 +44,32 @@
* @param path path to tombstone
* @return the entry.
*/
- public static PathMetadata tombstone(Path path) {
+ public static PathMetadata tombstone(Path path, long lastUpdated) {
S3AFileStatus s3aStatus = new S3AFileStatus(0,
System.currentTimeMillis(), path, 0, null,
null, null);
- return new PathMetadata(s3aStatus, Tristate.UNKNOWN, true);
+ return new PathMetadata(s3aStatus, Tristate.UNKNOWN, true, lastUpdated);
}
/**
* Creates a new {@code PathMetadata} containing given {@code FileStatus}.
* @param fileStatus file status containing an absolute path.
*/
public PathMetadata(S3AFileStatus fileStatus) {
- this(fileStatus, Tristate.UNKNOWN, false);
+ this(fileStatus, Tristate.UNKNOWN, false, 0);
Review comment:
extend javadpcs to mention that lastUpdated == 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
