[
https://issues.apache.org/jira/browse/HADOOP-16380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881050#comment-16881050
]
Steve Loughran commented on HADOOP-16380:
-----------------------------------------
one of the places where the check for an empty dir is made is in delete(path,
recursive)
# if recursive==false, the empty dir flag is used to decide whether to
accept/reject the request.
# when the dir is deleted, only an empty dir marker is cut....there's no scan
for children. "it's empty, innit?"
Because of #2, there's no way to correct the situation of file-under-tombstone
except by pruning all tombstones and trying again.
One thing to consider: when deleting any directory, *and recursive==true*,
ignore all tombstones and explicitly DELETE all entries returned in listings,
tombstone or not. This would at least make is self correcting of files arriving
under tombstones
> S3Guard tombstones can mislead about directory empty status
> -----------------------------------------------------------
>
> Key: HADOOP-16380
> URL: https://issues.apache.org/jira/browse/HADOOP-16380
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.2.0, 3.0.3, 3.3.0, 3.1.2
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Critical
>
> If S3AFileSystem does an S3 LIST restricted to a single object to see if a
> directory is empty, and the single entry found has a tombstone marker (either
> from an inconsistent DDB Table or from an eventually consistent LIST) then it
> will consider the directory empty, _even if there is 1+ entry which is not
> deleted_
> We need to make sure the calculation of whether a directory is empty or not
> is resilient to this, efficiently.
> It surfaces as an issue two places
> * delete(path) (where it may make things worse)
> * rename(src, dest), where a check is made for dest != an empty directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
