ajfabbri commented on a change in pull request #951: HADOOP-15183. S3Guard
store becomes inconsistent after partial failure of rename
URL: https://github.com/apache/hadoop/pull/951#discussion_r295517219
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/DynamoDBMetadataStore.java
##########
@@ -2210,6 +2233,17 @@ public AncestorState initiateBulkWrite(
return new AncestorState(operation, dest);
}
+ /**
+ * Extract a time provider from the argument or fall back to the
+ * one in the constructor.
+ * @param ttlTimeProvider nullable time source passed in as an argument.
+ * @return a non-null time source.
+ */
+ private ITtlTimeProvider extractTimeProvider(
+ @Nullable ITtlTimeProvider ttlTimeProvider) {
+ return ttlTimeProvider != null ? ttlTimeProvider : timeProvider;
+ }
+
Review comment:
As we discussed w/ @bgaborg @mackrorysd this will go away soon, and is fine
for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
