steveloughran commented on issue #970: HADOOP-16371: Option to disable GCM for SSL connections when running on Java 8 URL: https://github.com/apache/hadoop/pull/970#issuecomment-503498567 > (did not have S3Guard or kms tests setup) You are going to have to do S3Guard tests here because that talks to another AWS endpoint, and it's important to know if there are any regressions. I'm not worried about the KMS stuff, or the assumed role code; there's enough test of AWS Session credentials that talking to AWS STS is handled. FWIW, we directly talk to the following service s in production code * AWS S3 * AWS Secure Token Service * DynamoDB We need to make sure we are going near all of them. I've just been looking to see where there's already a good parameterized test we could (abuse) to add another option to the config set, so guaranteeing coverage of interaction with these services without adding new tests (and new test delays). Nothing immediately springs to mind, though `ITestS3AContractSeek` seems like a good choice. Adding an extra column for each of the three options to set the SSL binding would verify that the seek code was happy with it and that, when run with s3guard enabled, we'd be implicitly testing that. Sahil: what would you think about replacing `ITestS3ASSL` with some extra parameterization of the `ITestS3AContractSeek` test? I know it's nominally wrong to mix things up this way, but it would (a) not make test time any worse than it is and (b) do a more rigorous test: the seek code is skipping around, aborting connections etc?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
