steveloughran commented on a change in pull request #970: HADOOP-16371: Option
to disable GCM for SSL connections when running on Java 8
URL: https://github.com/apache/hadoop/pull/970#discussion_r295207938
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/DelegatingSSLSocketFactory.java
##########
@@ -234,7 +274,8 @@ private void configureSocket(SSLSocket ss) throws
SocketException {
// Remove GCM mode based ciphers from the supported list.
for (int i = 0; i < defaultCiphers.length; i++) {
if (defaultCiphers[i].contains("_GCM_")) {
- LOG.debug("Removed Cipher - " + defaultCiphers[i]);
+ LOG.debug("Removed Cipher - " + defaultCiphers[i] + " from list of " +
+ "enabled SSLSocket ciphers");
Review comment:
use SLF4J {} expansion rather than inline; there's a lot of commons-logging
era log statements, and changing a line is the time to upgrade them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
