ehiggs commented on a change in pull request #743: HADOOP-11452 make rename/3
public
URL: https://github.com/apache/hadoop/pull/743#discussion_r294668837
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
##########
@@ -670,6 +670,27 @@ public boolean rename(Path src, Path dst) throws
IOException {
}
}
+ /**
+ * Rename files/dirs.
+ */
+ @Override
+ @SuppressWarnings("deprecation")
+ public void rename(final Path src,
+ Path dst,
+ final Options.Rename... options)
+ throws IOException {
+ fs.rename(src, dst, options);
Review comment:
The deprecated version checks the return code here and bails if the rename
wasn't successful. If Options includes Options.Rename.NONE and dst already
exists, this will return false? If so, we shouldn't proceed to overwrite the
checksums.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
